![]() | |||||||||||
Messages in this thread Complete thread (EXPERIMENTAL) |
Russell King wrote:
It's not really "I/O port resource allocation" though - the resources
have already been allocated and potentially programmed into the BARs
well before the driver gets anywhere near the device.
[...]Are you implying that somehow resources are allocated at pci_enable_device
time? If so, shouldn't we be thinking of moving completely to that model
rather than having yet-another-pci-setup-model.
Actually, that's has been the rule ever since the cardbus days: resources -- bars and irqs -- should not be considered allocated until after pci_enable_device(). However, practically, cardbus have always had and continue to have their resources setup prior to driver probe. Documentation/pci.txt reflects this reality as well:
3. Enabling and disabling devices
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Before you do anything with the device you've found, you need to enable it by calling pci_enable_device() which enables I/O and memory regions of the device, allocates an IRQ if necessary, assigns missing resources if needed and wakes up the device if it was in suspended state. Please note that this function can fail. Any PCI driver that presumes -anything- about resources before calling pci_enable_device() is buggy, and that's been the case for many years. Some platform-specific PCI drivers violate this with special knowledge, but overall that's the rule. Nevertheless, my basic point that the no_ioport solution only addresses one problem area, while being far too late for the other methods still stands. Maybe the setup-* stuff needs to be rewritten (in which case cardbus will also convert to the "new" system automatically)? Given the problems of allocating resources for bridges inside cardbus cards, it would be nice if this could happen, so the limited IO range provided to cardbus could be more efficiently (and selectively) used. Wouldn't you think that's a sane idea? -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core | ||||||||||
![]() | |||||||||||
| Last update: 2006-03-02 19:16 [W:0.118 / U:0.020 seconds] ©2003-2005 Jasper Spaans | |||||||||||