lkml.org 
[lkml]   [2005]   [Oct]   [12]   [last100]   RSS-feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Complete thread (EXPERIMENTAL)
/
DateWed, 12 Oct 2005 19:49:52 +1000
FromPaul Mackerras <>
SubjectRe: [PATCH 15/22] ppc64: PCI Error Recovery: PPC64 core recovery routines
Digg This
Linas writes:

+ /* We might not have a pci device, if it was a config space read + * that failed. Find the pci device now. */
+ if (!dev) {
+ while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) { + if (pci_device_to_OF_node(dev) == event->dn) + break;
+ }
+ }

Couldn't we just use PCI_DN(event->dn)->pcidev here? Is there some reason why this would not work in some circumstances? It would be nice to avoid this linear search.

Paul.
\
ISP Services
Valid XHTML 1.0!\ /
Valid CSS! Last update: 2005-10-12 09:59    [W:12.960 / U:8.590 seconds]
©2003-2005 Jasper Spaans