lkml.org 
[lkml]   [2002]   [Dec]   [9]   [last100]   RSS-feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Complete thread (EXPERIMENTAL)
/
DateMon, 9 Dec 2002 11:40:29 +0100
SubjectRe: [ACPI] Re: [2.5.50, ACPI] link error
FromDucrot Bruno <>
Digg This
On Sun, Dec 08, 2002 at 03:46:20PM -0500, Constantinos Antoniou wrote:
On Sun, 2002-12-08 at 14:49, Pavel Machek wrote:
Hi!

Doesn't that imply your fix is broken to begin with?

ACPI/S4 support needs swsusp. ACPI/S3 needs big part of swsusp. Splitting CONFIG_ACPI_SLEEP to S3 and S4 part seems like overdesign to me, OTOH if you do the work it is okay with me.

You broke the design. S3 support was developed long before swsusp was in the kernel, and completely indpendent of it. It should have remained that way.

S3 support is a subset of what is need for S4 support.

That's not true. acpi_wakeup.S is nasty piece of code, needed for S3 but not for S4. Big part of driver support is only needed for S3.
swsusp is an implementation of S4 support. In theory, there could be multiple implementations that all use the same core (saving/restoring state).

There were patches for S4bios floating around, but it never really worked, IIRC.

No. It work. I do not resubmmited patches because I think that swsusp is better.

I think that s4bios is nice to have. Its similar to S3 and easier to set up than swsusp... It would be nice to have it.

(I do not know much, but) another reason may be that some laptops do not support S3, while they support S4? for example, in my Compaq Presario 1700T:

$ more /proc/acpi/info
ACPI-CA Version: 20011018
Sx States Supported: S0 S1 S4 S5

Some southbrigdes have well know design flaw that prevent a 'good' S3 functionality. Those this is disabled.

-- 
Ducrot Bruno
http://www.poupinou.org        Page profaissionelle
http://toto.tu-me-saoules.com  Haume page
\
ISP Services
Valid XHTML 1.0!\ /
Valid CSS! Last update: 2005-03-22 12:31    [W:0.300 / U:0.020 seconds]
©2003-2005 Jasper Spaans