lkml.org 
[lkml]   [2024]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] selftests: filesystems: add missing stddef header
From
On 4/22/24 15:49, Muhammad Usama Anjum wrote:
> On 4/22/24 6:16 PM, Amer Al Shanawany wrote:
>> fix compiler warning and errors when compiling statmount test.
>>
>> gcc 12.3 (Ubuntu 12.3.0-1ubuntu1~22.04)
>>
>> statmount_test.c:572:24: warning: implicit declaration of function
>> ‘offsetof’ [-Wimplicit-function-declaration]
>> 572 | #define str_off(memb) (offsetof(struct statmount, memb) /
>> sizeof(uint32_t))
>> | ^~~~~~~~
>> statmount_test.c:598:51: note: in expansion of macro ‘str_off’
>> 598 | test_statmount_string(STATMOUNT_MNT_ROOT,
>> str_off(mnt_root), "mount root");
>> |
>> ^~~~~~~
>> statmount_test.c:18:1: note: ‘offsetof’ is defined in header
>> ‘<stddef.h>’; did you forget to ‘#include <stddef.h>’?
>> 17 | #include "../../kselftest.h"
>> +++ |+#include <stddef.h>
>>
>> Signed-off-by: Amer Al Shanawany <amer.shanawany@gmail.com>
> You missed the reviewed-by tag from previous iteration. Putting it here again:
>
> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>
>> ---
>> V1 -> V2 added compiler warning in the patch message
>>
>> tools/testing/selftests/filesystems/statmount/statmount_test.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/filesystems/statmount/statmount_test.c b/tools/testing/selftests/filesystems/statmount/statmount_test.c
>> index 3eafd7da58e2..e6d7c4f1c85b 100644
>> --- a/tools/testing/selftests/filesystems/statmount/statmount_test.c
>> +++ b/tools/testing/selftests/filesystems/statmount/statmount_test.c
>> @@ -3,6 +3,7 @@
>> #define _GNU_SOURCE
>>
>> #include <assert.h>
>> +#include <stddef.h>
>> #include <stdint.h>
>> #include <sched.h>
>> #include <fcntl.h>
Hi,

Could you please consider this patch?

Thank you

Amer

\
 
 \ /
  Last update: 2024-05-27 18:15    [W:0.055 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site