lkml.org 
[lkml]   [2024]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/4] regulator: rtq2208: Fix LDO to be compatible with both fixed and adjustable vout
On Thu, May 02, 2024 at 03:30:29PM +0800, Alina Yu wrote:
> On Wed, May 01, 2024 at 11:19:05AM +0900, Mark Brown wrote:
> > On Tue, Apr 30, 2024 at 05:58:25PM +0800, Alina Yu wrote:

> > > + if (init_data->constraints.min_uV == init_data->constraints.max_uV) {
> > > + desc->n_voltages = 1;
> > > + desc->fixed_uV = init_data->constraints.min_uV;
> > > + desc->ops = &rtq2208_regulator_ldo_fix_ops;
> > > + } else {
> > > + desc->n_voltages = ARRAY_SIZE(rtq2208_ldo_volt_table);
> > > + desc->volt_table = rtq2208_ldo_volt_table;
> > > + desc->ops = &rtq2208_regulator_ldo_adj_ops;
> > > + }

> > Why are you making this change? The operations supported by the
> > regulator don't change depending on if the system is going to chnage the
> > voltage.

> The change is necessary due to the requirement of the SD card for high/default and ultra-high-speed modes. The system needs to adjust the LDO Vout accordingly.
> In ultra-high-speed mode, the LDO Vout needs to be adjusted to 1.8V; otherwise, it will remain at 1.8V.

That just sounds like normal constraints usage, and something that
applies to a wide variety of systems not just this specific regulator.
If there are limits on what voltages can be configured the constraints
will enforce them.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2024-05-03 03:37    [W:0.068 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site