Messages in this thread | | | Date | Wed, 1 May 2024 16:14:00 +0200 | From | Greg KH <> | Subject | Re: [PATCH 1/2] staging: pi433: Use class_create instead of class_register. |
| |
On Wed, May 01, 2024 at 05:00:44PM +0300, Dan Carpenter wrote: > On Wed, May 01, 2024 at 08:58:19AM +0300, Shahar Avidar wrote: > > Make use of a higher level API. > > Reduce global memory allocation from struct class to pointer size. > > Doesn't this move the memory in the opposite direction from what we > want? Originally, it's static const. Isn't that the simplest best > kind of memory?
Our reviews just crossed... This is just a revert (in 2 steps oddly), of a previous commit that changed this api call, and for that reason alone we can't take it :)
thanks,
greg k-h
| |