lkml.org 
[lkml]   [2024]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next 3/6] flow_offload: add flow_rule_no_control_flags()
Date
On April 8, 2024 9:09 PM, Asbjørn wrote:

>This helper can be used by drivers, that doesn't support any control flags, to
>reject any attempt to install rules with control flags.
>
>This is aimed at drivers, which uses flow_rule_match_control(), but doesn't
>implement any control flags.
>
>Only compile-tested.
>
>Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
>---
> include/net/flow_offload.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
>diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h index
>c1317b14da08c..415d225204a1f 100644
>--- a/include/net/flow_offload.h
>+++ b/include/net/flow_offload.h
>@@ -471,6 +471,19 @@ static inline bool
>flow_rule_no_unsupp_control_flags(const u32 supp_flags,
> return false;
> }
>
>+/**
>+ * flow_rule_no_control_flags() - check for presence of any control
>+flags
>+ * @flags: flags present in rule
>+ * @extack: The netlink extended ACK for reporting errors.
>+ *
>+ * Returns true if no control flags are set, false otherwise.
>+ */
>+static inline bool flow_rule_no_control_flags(const u32 flags,
>+ struct netlink_ext_ack *extack) {
>+ return flow_rule_no_unsupp_control_flags(0, flags, extack); }
>+
How about to squash this change with series I patch since they have similar functions for driver to use.
> struct flow_stats {
> u64 pkts;
> u64 bytes;
>--
>2.43.0

\
 
 \ /
  Last update: 2024-05-27 16:30    [W:0.254 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site