Messages in this thread | | | From | Shengjiu Wang <> | Date | Tue, 9 Apr 2024 09:37:05 +0800 | Subject | Re: [PATCH v2] ASoC: dt-bindings: imx-audio-spdif: convert to YAML |
| |
On Mon, Apr 8, 2024 at 11:06 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 08/04/2024 10:01, Shengjiu Wang wrote: > >>> + > >>> +anyOf: > >>> + - required: > >>> + - spdif-in > >>> + - required: > >>> + - spdif-out > >>> + - required: > >>> + - spdif-out > >>> + - spdif-in > >> > >> Do you need the last required block? > > > > Yes, one of them or both are required. > > And? It's already there: that's the meaning of any. It is not oneOf... > Before answering please test your changes and ideas. I pointed issue > here and you responded just to close my comment. That does not make me > happy, just wastes my time.
Maybe I didn't express clearly.
we need at least one of them (spdif-in, spdif-out) in the node. which means that we need to select "spdif-in", or "spdif-out", or "spdif-in and spdif-out".
So my understanding is that need to use "anyOf", if it is wrong, please let me know.
> > > > >> > >>> + > >>> +additionalProperties: false > >>> + > >>> +examples: > >>> + - | > >>> + sound { > >> > >> That's a random change...
So I can use "sound-spdif", right?
best regards wang shengjiu
> >> > >> Instead of sending two patches per day, please carefully address the > >> feedback. > > > > In v1 you suggest to change it to spdif? but spdif may conflict > > with the fsl,spdif.yaml. so which name I should use? > > I don't understand where is the conflict. That's a different binding. > >
| |