Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Tue, 09 Apr 2024 10:39:22 -0000 | From | "tip-bot2 for Li Zhijian" <> | Subject | [tip: timers/core] clocksource: Convert s[n]printf() to sysfs_emit() |
| |
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 8f0acb7f3a1331559e325566c00c26d1523dfe06 Gitweb: https://git.kernel.org/tip/8f0acb7f3a1331559e325566c00c26d1523dfe06 Author: Li Zhijian <lizhijian@fujitsu.com> AuthorDate: Thu, 14 Mar 2024 18:04:01 +08:00 Committer: Thomas Gleixner <tglx@linutronix.de> CommitterDate: Tue, 09 Apr 2024 12:32:37 +02:00
clocksource: Convert s[n]printf() to sysfs_emit()
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.
coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit().
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/r/20240314100402.1326582-1-lizhijian@fujitsu.com --- kernel/time/clocksource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index 4d50d53..d25ba49 100644 --- a/kernel/time/clocksource.c +++ b/kernel/time/clocksource.c @@ -1334,7 +1334,7 @@ static ssize_t current_clocksource_show(struct device *dev, ssize_t count = 0; mutex_lock(&clocksource_mutex); - count = snprintf(buf, PAGE_SIZE, "%s\n", curr_clocksource->name); + count = sysfs_emit(buf, "%s\n", curr_clocksource->name); mutex_unlock(&clocksource_mutex); return count;
| ![\](/images/icornerr.gif) |