Messages in this thread | | | Date | Tue, 9 Apr 2024 09:34:37 +0200 | Subject | Re: [PATCH 3/9] dt-bindings: rtc: lpc32xx-rtc: move to trivial-rtc | From | Krzysztof Kozlowski <> |
| |
On 08/04/2024 17:53, Javier Carrasco wrote: > This RTC requires a compatible, a reg and a single interrupt, > which makes it suitable for a direct conversion into trivial-rtc. > > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> > --- > Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt | 15 --------------- > Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++ > 2 files changed, 2 insertions(+), 15 deletions(-)
This one no... and if you tested DTS you would see errors, although you need to test specific lpc config, not multi_v7.
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions).
Anyway, you *must* check all DTS before moving anything to trivial.
Does it mean all other bindings were not checked against DTS at all?
Best regards, Krzysztof
| |