Messages in this thread | | | Date | Tue, 09 Apr 2024 15:49:11 -0500 | From | Rob Herring <> | Subject | Re: [PATCH v2 5/7] dt-bindings: phy: qcom,ipq8074-qmp-pcie: add ipq9574 gen3x2 PHY |
| |
On Tue, 09 Apr 2024 14:08:31 -0500, Alexandru Gagniuc wrote: > The IPQ9574 gen3x2 PHY is very similar to IPQ6018. It requires two > extra clocks named "anoc" and "snoc". Document this, and add a > new compatible string for this PHY. > > Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> > --- > .../phy/qcom,ipq8074-qmp-pcie-phy.yaml | 31 ++++++++++++++++++- > 1 file changed, 30 insertions(+), 1 deletion(-) >
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.example.dtb: phy@84000: clock-names: ['aux', 'cfg_ahb', 'pipe'] is too short from schema $id: http://devicetree.org/schemas/phy/qcom,ipq8074-qmp-pcie-phy.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240409190833.3485824-6-mr.nuke.me@gmail.com
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
| |