Messages in this thread | | | Date | Tue, 9 Apr 2024 20:13:14 +0200 | Subject | Re: [PATCH 5/6] drm/msm/adreno: Add speedbin data for SM8550 / A740 | From | Konrad Dybcio <> |
| |
On 4/9/24 17:24, Dmitry Baryshkov wrote: > On Tue, Apr 09, 2024 at 05:13:15PM +0200, Konrad Dybcio wrote: >> >> >> On 4/6/24 05:25, Dmitry Baryshkov wrote: >>> On Fri, Apr 05, 2024 at 10:41:33AM +0200, Konrad Dybcio wrote: >>>> Add speebin data for A740, as found on SM8550 and derivative SoCs. >>>> >>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>>> --- >>>> drivers/gpu/drm/msm/adreno/adreno_device.c | 14 ++++++++++++++ >>>> 1 file changed, 14 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c >>>> index 901ef767e491..c976a485aef2 100644 >>>> --- a/drivers/gpu/drm/msm/adreno/adreno_device.c >>>> +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c >>>> @@ -570,6 +570,20 @@ static const struct adreno_info gpulist[] = { >>>> .zapfw = "a740_zap.mdt", >>>> .hwcg = a740_hwcg, >>>> .address_space_size = SZ_16G, >>>> + .speedbins = ADRENO_SPEEDBINS( >>> >>> I think this deserves either a comment or some info in the commit >>> message. >> >> "this" = ? > > I see two types of speedbins here, it would be nice to understand at > least some reason or some defailts for that (if you know them).
"one is slightly faster"
sorry, qcom downstream has been getting increasingly cryptic lately..
Konrad
| |