lkml.org 
[lkml]   [2024]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] [RESEND] orangefs: fix out-of-bounds fsid access
    I applied Arnd's patch on top of Linux 6.9-rc3 and
    ran through xfstests with no issue.

    Also, instead of Arnd's patch, I used Jan's idea:

    +
    + buf->f_fsid.val[0] = ORANGEFS_SB(sb)->fs_id;
    + buf->f_fsid.val[1] = ORANGEFS_SB(sb)->id;
    +

    And ran that through as well, no issue.

    Sorry for missing the earlier patch.

    -Mike

    On Tue, Apr 9, 2024 at 1:55 AM Arnd Bergmann <arnd@arndb.de> wrote:
    >
    > On Mon, Apr 8, 2024, at 23:21, Justin Stitt wrote:
    > > On Mon, Apr 8, 2024 at 7:36 AM Jan Kara <jack@suse.cz> wrote:
    > >> Frankly, this initializer is hard to understand for me. Why not simple:
    > >>
    > >> buf->f_fsid[0] = ORANGEFS_SB(sb)->fs_id;
    > >> buf->f_fsid[1] = ORANGEFS_SB(sb)->id;
    > >>
    > >
    > > +1 for this idea, seems easier to read for me.
    >
    > Yes, good idea, I'll send this as v2 after my next round
    > of build testing.
    >
    > Arnd

    \
     
     \ /
      Last update: 2024-05-27 16:31    [W:3.071 / U:0.516 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site