lkml.org 
[lkml]   [2024]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC PATCH v2 0/2] fw_devlink overlay fix
    Hi Saravana,

    On Tue, Apr 9, 2024 at 7:37 AM Saravana Kannan <saravanak@google.com> wrote:
    > Don't bother reviewing this patch. It needs to be tested and possibly
    > refactored first.
    >
    > Geert and Herve,
    >
    > This patch serious should hopefully fix both of your use cases
    > [1][2][3]. Can you please check to make sure the device links created
    > to/from the overlay devices are to/from the right ones?

    Thanks for your series!

    After applying the first patch (the revert), the issue reported in
    [1] is back, as expected.
    After applying both patches, applying[A]/unapplying[B]/reapplying[C]
    overlay [4] works as without this series, so
    Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

    Note that the state of /sys/class/devlink/ after [C] is still not the
    same as after [A], as reported before in [5]:
    - platform:e6060000.pinctrl--platform:keys link is not recreated in [B],
    - nothing changes in /sys/class/devlink in [C].
    But that issue is not introduced in this series.

    > [1] - https://lore.kernel.org/lkml/CAMuHMdXEnSD4rRJ-o90x4OprUacN_rJgyo8x6=9F9rZ+-KzjOg@mail.gmail.com/

    [4] "arm64: dts: renesas: ebisu: cn41: Add overlay for MSIOF0 and 25LC040"
    https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=topic/renesas-overlays&id=222a4936b0d3dabd43bdffb3a578423bff97b02d
    [5] https://lore.kernel.org/lkml/CAMuHMdXNoYH8PJE1xb4PK-vzjXtOzrxNJoZhsHT-H4Ucm=7_ig@mail.gmail.com/

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2024-05-27 16:31    [W:2.927 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site