lkml.org 
[lkml]   [2024]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: soc-card: Fix a reversed if condition
On Mon, Apr 08, 2024 at 01:43:09PM +0100, Mark Brown wrote:
> On Mon, Apr 08, 2024 at 10:38:02AM +0300, Dan Carpenter wrote:
>
> > ret = snd_soc_register_card(priv->card);
> > - if (!ret)
> > + if (ret)
> > return ret;
> >
> > return 0;
>
> Clearly a better fix here would just be to remove the conditional
> entirely.

Hm... Actually, it should be:

if (ret) {
put_device(priv->card_dev);
return ret;
}

return 0;

Let me resend with that instead.

regards,
dan carpenter

\
 
 \ /
  Last update: 2024-05-27 16:28    [W:0.072 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site