Messages in this thread | | | Date | Mon, 8 Apr 2024 14:32:24 +0300 | Subject | Re: [Intel-wired-lan] [PATCH 3/3] igc: Remove redundant runtime resume for ethtool ops | From | "naamax.meir" <> |
| |
On 3/26/2024 00:29, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > 8c5ad0dae93c ("igc: Add ethtool support") added ethtool_ops.begin() and > .complete(), which used pm_runtime_get_sync() to resume suspended devices > before any ethtool_ops callback and allow suspend after it completed. > > Subsequently, f32a21376573 ("ethtool: runtime-resume netdev parent before > ethtool ioctl ops") added pm_runtime_get_sync() in the dev_ethtool() path, > so the device is resumed before any ethtool_ops callback even if the driver > didn't supply a .begin() callback. > > Remove the .begin() and .complete() callbacks, which are now redundant > because dev_ethtool() already resumes the device. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > --- > drivers/net/ethernet/intel/igc/igc_ethtool.c | 17 ----------------- > 1 file changed, 17 deletions(-)
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
| |