Messages in this thread | | | Date | Mon, 8 Apr 2024 13:29:32 +0200 | From | Michal Koutný <> | Subject | Re: Re: [RFC PATCH v3 6/9] selftests: cgroup: Add basic tests for pids controller |
| |
On Sun, Apr 07, 2024 at 02:37:44AM +0500, Muhammad Usama Anjum <usama.anjum@collabora.com> wrote: > The > ksft_print_header(); > ksft_set_plan(total_number_of_tests); > are missing. Please use all of the ksft APIs to make the test TAP compliant.
Will do.
> > + for (i = 0; i < ARRAY_SIZE(tests); i++) { > > + switch (tests[i].fn(root)) { > > + case KSFT_PASS: > > + ksft_test_result_pass("%s\n", tests[i].name); > > + break; > > + case KSFT_SKIP: > > + ksft_test_result_skip("%s\n", tests[i].name); > > + break; > > + default: > > + ret = EXIT_FAILURE; > > + ksft_test_result_fail("%s\n", tests[i].name); > > + break; > Use ksft_test_result_report() instead of swith-case here.
Do you mean ksft_test_result()? That one cannot distinguish the KSFT_SKIP case. Or ksft_test_result_code(tests[i].fn(root), tests[i].name)?
Would the existing ksft_test_resul_*() calls inside switch-case still TAP-work?
Thanks, Michal [unhandled content-type:application/pgp-signature] | |