Messages in this thread | | | From | Alice Ryhl <> | Date | Mon, 8 Apr 2024 09:57:52 +0200 | Subject | Re: [PATCH 3/9] rust: list: add struct with prev/next pointers |
| |
On Fri, Apr 5, 2024 at 11:47 AM Benno Lossin <benno.lossin@proton.me> wrote: > > On 02.04.24 14:17, Alice Ryhl wrote: > > +impl<const ID: u64> ListLinks<ID> { > > + /// Creates a new initializer for this type. > > + pub fn new() -> impl PinInit<Self> { > > + // INVARIANT: Pin-init initializers can't be used on an existing `Arc`, so this value will > > + // not be constructed in an `Arc` that already has a `ListArc`. > > + ListLinks { > > + inner: Opaque::new(ListLinksFields { > > + prev: ptr::null_mut(), > > + next: ptr::null_mut(), > > + }), > > You might want to implement `Zeroable` (using the derive macro) for this > struct, since then you could just return `init::zeroed()`. > You can also use that for the `ListLinksSelfPtr` in the other patch.
Sure, that makes sense to me. I'll go for that.
Alice
| |