lkml.org 
[lkml]   [2024]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/9] MIPS: asm: Move strings to .rodata.str section
From
On 26/3/24 21:35, Jiaxun Yang wrote:
> Well, they are read only.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> arch/mips/include/asm/asm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/asm.h b/arch/mips/include/asm/asm.h
> index 2e99450f4228..05a158a8920c 100644
> --- a/arch/mips/include/asm/asm.h
> +++ b/arch/mips/include/asm/asm.h
> @@ -94,7 +94,7 @@ symbol: .insn
> symbol = value
>
> #define TEXT(msg) \
> - .pushsection .data; \
> + .pushsection .rodata.str; \

Nitpicking, \ is now misaligned.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> 8: .asciiz msg; \
> .popsection;
>
>


\
 
 \ /
  Last update: 2024-05-27 16:28    [W:0.170 / U:1.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site