lkml.org 
[lkml]   [2024]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 fs/proc/bootconfig 1/2] fs/proc: remove redundant comments from /proc/bootconfig
    Date
    From: Zhenhua Huang <quic_zhenhuah@quicinc.com>

    commit 717c7c894d4b ("fs/proc: Add boot loader arguments as comment to
    /proc/bootconfig") adds bootloader argument comments into /proc/bootconfig.

    /proc/bootconfig shows boot_command_line[] multiple times following
    every xbc key value pair, that's duplicated and not necessary.
    Remove redundant ones.

    Output before and after the fix is like:
    key1 = value1
    *bootloader argument comments*
    key2 = value2
    *bootloader argument comments*
    key3 = value3
    *bootloader argument comments*
    ..

    key1 = value1
    key2 = value2
    key3 = value3
    *bootloader argument comments*
    ..

    Fixes: 717c7c894d4b ("fs/proc: Add boot loader arguments as comment to /proc/bootconfig")
    Signed-off-by: Zhenhua Huang <quic_zhenhuah@quicinc.com>
    Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
    Cc: <linux-trace-kernel@vger.kernel.org>
    Cc: <linux-fsdevel@vger.kernel.org>
    Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
    ---
    fs/proc/bootconfig.c | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    diff --git a/fs/proc/bootconfig.c b/fs/proc/bootconfig.c
    index 902b326e1e560..e5635a6b127b0 100644
    --- a/fs/proc/bootconfig.c
    +++ b/fs/proc/bootconfig.c
    @@ -62,12 +62,12 @@ static int __init copy_xbc_key_value_list(char *dst, size_t size)
    break;
    dst += ret;
    }
    - if (ret >= 0 && boot_command_line[0]) {
    - ret = snprintf(dst, rest(dst, end), "# Parameters from bootloader:\n# %s\n",
    - boot_command_line);
    - if (ret > 0)
    - dst += ret;
    - }
    + }
    + if (ret >= 0 && boot_command_line[0]) {
    + ret = snprintf(dst, rest(dst, end), "# Parameters from bootloader:\n# %s\n",
    + boot_command_line);
    + if (ret > 0)
    + dst += ret;
    }
    out:
    kfree(key);
    --
    2.40.1

    \
     
     \ /
      Last update: 2024-05-27 16:30    [W:3.679 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site