Messages in this thread | | | Date | Mon, 8 Apr 2024 16:20:52 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v3] net: dsa: lan9303: use ethtool_puts() for lan9303_get_strings() |
| |
On Mon, Apr 08, 2024 at 09:01:57PM +0000, Justin Stitt wrote: > This pattern of strncpy with some pointer arithmetic setting fixed-sized > intervals with string literal data is a bit weird so let's use > ethtool_puts() as this has more obvious behavior and is less-error > prone. > > Nicely, we also get to drop a usage of the now deprecated strncpy() [1]. > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-hardening@vger.kernel.org > Cc: Kees Cook <keescook@chromium.org> > Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |