Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 8 Apr 2024 10:37:29 -0500 | Subject | Re: [PATCH] ASoC: Intel: sof_rt5682: Fix uninitialized variable in probe | From | Pierre-Louis Bossart <> |
| |
On 4/8/24 02:35, Dan Carpenter wrote: > Initialize "is_legacy_cpu" to false to prevent an uninitialized variable > bug. > > Fixes: 8efcd4864652 ("ASoC: Intel: sof_rt5682: use common module for sof_card_private initialization") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Good catch.
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> --- > sound/soc/intel/boards/sof_rt5682.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/boards/sof_rt5682.c b/sound/soc/intel/boards/sof_rt5682.c > index aadd341a202c..966bcd3e8bdc 100644 > --- a/sound/soc/intel/boards/sof_rt5682.c > +++ b/sound/soc/intel/boards/sof_rt5682.c > @@ -606,7 +606,7 @@ static int sof_audio_probe(struct platform_device *pdev) > { > struct snd_soc_acpi_mach *mach = pdev->dev.platform_data; > struct sof_card_private *ctx; > - bool is_legacy_cpu; > + bool is_legacy_cpu = false; > int ret; > > if (pdev->id_entry && pdev->id_entry->driver_data)
| ![\](/images/icornerr.gif) |