Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 7 Apr 2024 12:48:32 -0500 | Subject | Re: [PATCH v4 3/5] spi: spi-qpic: Add qpic spi nand driver support | From | "Alex G." <> |
| |
On 3/8/24 03:17, Md Sadre Alam wrote: > Add qpic spi nand driver support. The spi nand > driver currently supported the below commands. > > -- RESET > -- READ ID > -- SET FEATURE > -- GET FEATURE > -- READ PAGE > -- WRITE PAGE > -- ERASE PAGE > > Co-developed-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > Co-developed-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com> > ---
For the entire series:
Tested-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index bc7021da2fe9..63764e943d82 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -882,6 +882,14 @@ config SPI_QCOM_QSPI > help > QSPI(Quad SPI) driver for Qualcomm QSPI controller. > > +config SPI_QPIC_SNAND > + tristate "QPIC SNAND controller" > + depends on ARCH_QCOM || COMPILE_TEST
Here, it needs to 'select QPIC_COMMON`. Otherwise it can run into unresolved symbols:
: drivers/spi/spi-qpic-snand.o: in function `snandc_set_reg': drivers/spi/spi-qpic-snand.c:56:(.text+0x484): undefined reference to `qcom_offset_to_nandc_reg' ..
> + help > + QPIC_SNAND (QPIC SPI NAND) driver for Qualcomm QPIC controller. > + QPIC controller supports both parallel nand and serial nand. > + This config will enable serial nand driver for QPIC controller. > + > config SPI_QUP > tristate "Qualcomm SPI controller with QUP interface" > depends on ARCH_QCOM || COMPILE_TEST
Alex
| ![\](/images/icornerr.gif) |