Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 7 Apr 2024 11:12:16 +0200 | Subject | Re: [EXT] Re: [PATCH v1 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support | From | Krzysztof Kozlowski <> |
| |
On 07/04/2024 11:09, Joy Zou wrote: > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 2024年4月7日 17:04 >> To: Joy Zou <joy.zou@nxp.com>; Jacky Bai <ping.bai@nxp.com>; >> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; >> conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de >> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx >> <linux-imx@nxp.com>; devicetree@vger.kernel.org; imx@lists.linux.dev; >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org >> Subject: [EXT] Re: [PATCH v1 1/1] arm64: dts: imx93-11x11-evk: add rtc >> PCF2131 support >>> +&lpi2c3 { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + clock-frequency = <400000>; >>> + pinctrl-names = "default", "sleep"; >>> + pinctrl-0 = <&pinctrl_lpi2c3>; >>> + pinctrl-1 = <&pinctrl_lpi2c3>; >>> + status = "okay"; >>> + >>> + pcf2131: rtc@53 { >>> + compatible = "nxp,pcf2131"; >>> + reg = <0x53>; >>> + interrupt-parent = <&pcal6524>; >>> + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; >>> + status = "okay"; >> >> Really, just drop... > Ok, will drop the status in next version. > Thanks for your comment!
Please read DTS coding style.
Best regards, Krzysztof
| ![\](/images/icornerr.gif) |