Messages in this thread | | | From | Dmitry Baryshkov <> | Date | Sat, 6 Apr 2024 17:40:03 +0300 | Subject | Re: [PATCH v2] phy: qcom: m31: match requested regulator name with dt schema |
| |
On Sat, 6 Apr 2024 at 16:37, Gabor Juhos <j4g8y7@gmail.com> wrote: > > According to the 'qcom,ipq5332-usb-hsphy.yaml' schema, the 5V > supply regulator must be defined via the 'vdd-supply' property. > The driver however requests for the 'vdda-phy' regulator which > results in the following message when the driver is probed on > a IPQ5018 based board with a device tree matching to the schema: > > qcom-m31usb-phy 5b000.phy: supply vdda-phy not found, using dummy regulator > qcom-m31usb-phy 5b000.phy: Registered M31 USB phy > > This means that the regulator specified in the device tree never > gets enabled. > > Change the driver to use the 'vdd' name for the regulator as per > defined in the schema in order to ensure that the corresponding > regulator gets enabled. > > Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver") > Reviewed-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
-- With best wishes Dmitry
| |