Messages in this thread | | | Date | Fri, 5 Apr 2024 16:50:17 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v4 3/5] nvmet: return DHCHAP status codes from nvmet_setup_auth() |
| |
On Fri, Apr 05, 2024 at 04:47:52PM +0200, Christoph Hellwig wrote: > > Are you sure I should map this to errno codes and the back to NVME > > status codes? Sure, this is possible but don't really think it makes > > sense. > > No, but we should not overload the return value. Pass in the req > or sq, or add a new paramter for the auth fail reason.
Or make sure all returns are the status codes, change the return value to a u8 and clearly document what values it returns if that works out.
And while you're at it please fix all the overly long lines.
| |