Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 5 Apr 2024 14:40:50 +0200 | Subject | Re: [RESEND v7 13/37] dt-bindings: clock: sh7750-cpg: Add renesas,sh7750-cpg header. |
| |
Hi Sato-san,
Thanks for the update!
On Thu, Apr 4, 2024 at 7:15 AM Yoshinori Sato <ysato@users.sourceforge.jp> wrote: > > SH7750 CPG Clock output define.
(from my comments on v6) Please improve the patch description.
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> index 000000000000..04c10b0834ee > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/renesas,sh7750-cpg.yaml
The actual bindings LGTM.
> +examples: > + - | > + #include <dt-bindings/clock/sh7750-cpg.h> > + cpg: clock-controller@ffc00000 { > + #clock-cells = <1>; > + #power-domain-cells = <0>; > + compatible = "renesas,sh7751r-cpg"; > + clocks = <&extal>; > + clock-names = "extal"; > + reg = <0xffc00000 20>, <0xfe0a0000 16>; > + reg-names = "FRQCR", "CLKSTP00"; > + renesas,mode = <0>; > + };
Please read https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |