Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 5 Apr 2024 15:25:31 +0200 | Subject | Re: [RESEND v7 23/37] dt-bindings: display: sm501 register definition helper |
| |
Hi Sato-san,
Thanks for your patch!
On Thu, Apr 4, 2024 at 7:15 AM Yoshinori Sato <ysato@users.sourceforge.jp> wrote: > Miscellaneous Timing and Miscellaneous Control registers definition.
Please do not put raw register value definitions into DT bindings.
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> --- /dev/null > +++ b/include/dt-bindings/display/sm501.h
> +/* Miscellaneous timing */ > +#define SM501_MISC_TIMING_EX_HOLD_0 0 > +#define SM501_MISC_TIMING_EX_HOLD_16 1 > +#define SM501_MISC_TIMING_EX_HOLD_32 2 > +#define SM501_MISC_TIMING_EX_HOLD_48 3 > +#define SM501_MISC_TIMING_EX_HOLD_64 4 > +#define SM501_MISC_TIMING_EX_HOLD_80 5 > +#define SM501_MISC_TIMING_EX_HOLD_96 6 > +#define SM501_MISC_TIMING_EX_HOLD_112 7 > +#define SM501_MISC_TIMING_EX_HOLD_128 8 > +#define SM501_MISC_TIMING_EX_HOLD_144 9 > +#define SM501_MISC_TIMING_EX_HOLD_160 10 > +#define SM501_MISC_TIMING_EX_HOLD_176 11 > +#define SM501_MISC_TIMING_EX_HOLD_192 12 > +#define SM501_MISC_TIMING_EX_HOLD_208 13 > +#define SM501_MISC_TIMING_EX_HOLD_224 14 > +#define SM501_MISC_TIMING_EX_HOLD_240 15
E.g. these are used by the (not very descriptive) "ex" property:
ex: $ref: /schemas/types.yaml#/definitions/uint32 description: Extend bus holding time.
Please instead use an enum for the actual holding time ([ 0, 16, 32, ..]) in the DT bindings, and convert from actual holding time to register value in the driver.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |