Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 5 Apr 2024 10:54:22 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH v3 07/10] perf/hisi_pcie: Avoid placing cpumask on the stack |
| |
On Wed, 3 Apr 2024 23:59:47 +0800 Dawei Li <dawei.li@shingroup.cn> wrote:
> In general it's preferable to avoid placing cpumasks on the stack, as > for large values of NR_CPUS these can consume significant amounts of > stack space and make stack overflows more likely. > > Use cpumask_any_and_but() to avoid the need for a temporary cpumask on > the stack. > > Suggested-by: Mark Rutland <mark.rutland@arm.com> > Reviewed-by: Mark Rutland <mark.rutland@arm.com> > Signed-off-by: Dawei Li <dawei.li@shingroup.cn> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
| ![\](/images/icornerr.gif) |