Messages in this thread | | | Date | Fri, 5 Apr 2024 08:35:46 +0100 | Subject | Re: [PATCH v3 6/6] thermal: core: Relocate critical and hot trip handling | From | Lukasz Luba <> |
| |
Hi Rafael,
On 4/4/24 10:03, Rafael J. Wysocki wrote: > On Tue, Apr 2, 2024 at 9:04 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote: >> >> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> >> >> Modify handle_thermal_trip() to call handle_critical_trips() only after >> finding that the trip temperature has been crossed on the way up and >> remove the redundant temperature check from the latter. >> >> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > This change is premature, as it will cause handle_non_critical_trips() > to be called for hot/critical trips which is questionable, so I'm > withdrawing it for now. > > The rest of the series is still applicable, though. > >
Could you explain your concerns about this, please? Is about the extra execution time for the non-critical trip, while we are in section of handling critical ASAP? (also it would require that extra sorting there IMO)
Regards, Lukasz
| |