Messages in this thread | | | Date | Fri, 5 Apr 2024 08:16:24 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v4 1/5] nvme: authentication error are always non-retryable |
| |
> --- a/drivers/nvme/host/fabrics.c > +++ b/drivers/nvme/host/fabrics.c > @@ -467,7 +467,7 @@ int nvmf_connect_admin_queue(struct nvme_ctrl *ctrl) > if (result & NVME_CONNECT_AUTHREQ_ASCR) { > dev_warn(ctrl->device, > "qid 0: secure concatenation is not supported\n"); > - ret = NVME_SC_AUTH_REQUIRED; > + ret = NVME_SC_AUTH_REQUIRED | NVME_SC_DNR;
This is still abusing on the wire status code for in-kernel return codes. Can we please sort this out properly?
| |