Messages in this thread | | | Date | Fri, 5 Apr 2024 17:01:31 -0700 | Subject | Re: [PATCH 04/26] cxl/region: Add dynamic capacity decoder and region modes | From | Dave Jiang <> |
| |
On 4/5/24 11:19 AM, Ira Weiny wrote: > Dave Jiang wrote: >> >> >> On 3/24/24 4:18 PM, ira.weiny@intel.com wrote: >>> From: Navneet Singh <navneet.singh@intel.com> >>> >>> Region mode must reflect a general dynamic capacity type which is >>> associated with a specific Dynamic Capacity (DC) partitions in each >>> device decoder within the region. DC partitions are also know as DC >>> regions per CXL 3.1. >> >> This section reads somewhat awkward to me. Does this read any better? >> >> One or more Dynamic Capacity (DC) partitions (and decoders) form a CXL >> software region. The region mode reflects composition of that entire software >> region. Decoder mode reflects a specific DC partition. DC partitions are also >> known as DC regions per CXL specification r3.1 but is not the same entity as >> CXL software regions. > > Yea that does sound better but I think this builds on your text and is even > more clear. > > <commit> > cxl/region: Add dynamic capacity decoder and region modes > > One or more decoders each pointing to a Dynamic Capacity (DC) partition form a > CXL software region. The region mode reflects composition of that entire > software region. Decoder mode reflects a specific DC partition. DC partitions > are also known as DC regions per CXL specification r3.1 but they are not the > same entity as CXL software regions. > > Define the new modes and helper functions required to make the association > between these new modes. > > </commit> >
LGTM > > Ira
| |