Messages in this thread | | | Date | Fri, 5 Apr 2024 10:15:07 -0700 | Subject | Re: [PATCH v1 5/6] x86/resctrl: Abstract PQR_ASSOC from generic code | From | Reinette Chatre <> |
| |
Hi Peter,
On 3/25/2024 10:27 AM, Peter Newman wrote: > While CLOSID and RMID originated in RDT, the concept applies to other > architectures, as it's standard to write allocation and monitoring IDs > into per-CPU registers. > > - Rename resctrl_pqr_state and pqr_state to be more > architecturally-neutral. > > - Introduce resctrl_arch_update_cpu() to replace the explicit write to > MSR_IA32_PQR_ASSOC in __resctrl_sched_in(). In the case of MPAM, > PARTID[_I,D] and PMG are a simple function of closid, rmid, and an > internal global. > > - Update terminology containing explicit references to the PQR_ASSOC > register.
fyi ... I just noticed this while looking at the MPAM patches that there is an instance in comments of update_closid_rmid() where this was misspelled (PGR_ASSOC) and thus not picked up by your rename script.
Reinette
| |