Messages in this thread | ![/](/images/icornerl.gif) | | From | Vinod Koul <> | Subject | Re: [PATCH] phy: xilinx: Convert to platform remove callback returning void | Date | Fri, 05 Apr 2024 22:39:09 +0530 |
| |
On Fri, 08 Mar 2024 09:51:13 +0100, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > [...]
Applied, thanks!
[1/1] phy: xilinx: Convert to platform remove callback returning void commit: 7dcb8668aedc5603cba1f2625c6051beff03797d
Best regards, -- ~Vinod
| ![\](/images/icornerr.gif) |