Messages in this thread | | | Date | Fri, 5 Apr 2024 22:22:07 +0530 | Subject | Re: [PATCH v2 2/2] soc: qcom: pmic_glink: notify clients about the current state | From | Mukesh Ojha <> |
| |
On 4/3/2024 8:40 AM, Dmitry Baryshkov wrote: > In case the client is registered after the pmic-glink recived a response
received
> from the Protection Domain mapper, it is going to miss the notification > about the state. Notify clients about the current state upon > registration. > > Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver") > Reviewed-by: Andrew Halaney <ahalaney@redhat.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/soc/qcom/pmic_glink.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c > index 2b2cdf479654..e85a12ec2aab 100644 > --- a/drivers/soc/qcom/pmic_glink.c > +++ b/drivers/soc/qcom/pmic_glink.c > @@ -83,9 +83,14 @@ struct pmic_glink_client *devm_pmic_glink_register_client(struct device *dev, > client->pdr_notify = pdr; > client->priv = priv; > > + mutex_lock(&pg->state_lock); > mutex_lock(&pg->client_lock); > + > list_add(&client->node, &pg->clients); > + client->pdr_notify(client->priv, pg->client_state); > + > mutex_unlock(&pg->client_lock); > + mutex_unlock(&pg->state_lock);
LGTM,
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh > > devres_add(dev, client); > >
| |