Messages in this thread | | | Date | Tue, 30 Apr 2024 23:56:46 +0900 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: use inline function for type safety in snd_soc_substream_to_rtd() |
| |
On Tue, Apr 30, 2024 at 04:09:38PM +0200, Krzysztof Kozlowski wrote:
> -#define snd_soc_substream_to_rtd(substream) \ > - (struct snd_soc_pcm_runtime *)snd_pcm_substream_chip(substream) > + > +static inline struct snd_soc_pcm_runtime * > +snd_soc_substream_to_rtd(const struct snd_pcm_substream *substream) > +{ > + return substream->private_data; > +}
This is not an obvious direct substitution, we've skipped the snd_pcm_subsystem_chip() (which is also a macro, but that just suggests it could do with it's own cleanup) and the commit log didn't mention it. [unhandled content-type:application/pgp-signature] | |