lkml.org 
[lkml]   [2024]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [GIT PULL fixes PATCH] clk: samsung: Revert "clk: Use device_get_match_data()"
From
Date
Quoting Krzysztof Kozlowski (2024-04-30 11:46:56)
> From: Marek Szyprowski <m.szyprowski@samsung.com>
>
> device_get_match_data() function should not be used on the device other
> than the one matched to the given driver, because it always returns the
> match_data of the matched driver. In case of exynos-clkout driver, the
> original code matches the OF IDs on the PARENT device, so replacing it
> with of_device_get_match_data() broke the driver.
>
> This has been already pointed once in commit 2bc5febd05ab ("clk: samsung:
> Revert "clk: samsung: exynos-clkout: Use of_device_get_match_data()"").
> To avoid further confusion, add a comment about this special case, which
> requires direct of_match_device() call to pass custom IDs array.
>
> This partially reverts commit 409c39ec92a35e3708f5b5798c78eae78512cd71.
>
> Cc: <stable@vger.kernel.org>
> Fixes: 409c39ec92a3 ("clk: Use device_get_match_data()")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Link: https://lore.kernel.org/r/20240425075628.838497-1-m.szyprowski@samsung.com
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Applied to clk-fixes

\
 
 \ /
  Last update: 2024-05-27 18:11    [W:0.030 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site