Messages in this thread | | | From | Chaitanya Kulkarni <> | Subject | Re: [PATCH] nvme-fabrics: use reserved tag for reg read/write command | Date | Tue, 30 Apr 2024 17:42:16 +0000 |
| |
On 4/29/24 19:17, brookxu.cn wrote: > From: Chunguang Xu <chunguang.xu@shopee.com> > > In some scenarios, if too many commands are issued by nvme command in > the same time by user tasks, this may exhaust all tags of admin_q. If > a reset (nvme reset or IO timeout) occurs before these commands finish, > reconnect routine may fail to update nvme regs due to insufficient tags, > which will cause kernel hang forever. In order to workaround this issue, > maybe we can let reg_read32()/reg_read64()/reg_write32() use reserved > tags. This maybe safe for nvmf: > > 1. For the disable ctrl path, we will not issue connect command > 2. For the enable ctrl / fw activate path, since connect and reg_xx() > are called serially. > > So the reserved tags may still be enough while reg_xx() use reserved tags. > > Signed-off-by: Chunguang Xu <chunguang.xu@shopee.com> > --- >
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
| |