Messages in this thread | | | Date | Tue, 30 Apr 2024 18:31:40 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 6.6.y] kselftest: Add a ksft_perror() helper |
| |
On Tue, 30 Apr 2024, Greg KH wrote:
> On Tue, Apr 30, 2024 at 01:06:27AM +0000, Edward Liaw wrote: > > From: Mark Brown <broonie@kernel.org> > > > > [ Upstream commit 907f33028871fa7c9a3db1efd467b78ef82cce20 ] > > > > The standard library perror() function provides a convenient way to print > > an error message based on the current errno but this doesn't play nicely > > with KTAP output. Provide a helper which does an equivalent thing in a KTAP > > compatible format. > > > > nolibc doesn't have a strerror() and adding the table of strings required > > doesn't seem like a good fit for what it's trying to do so when we're using > > that only print the errno. > > > > Signed-off-by: Mark Brown <broonie@kernel.org> > > Reviewed-by: Kees Cook <keescook@chromium.org> > > Signed-off-by: Shuah Khan <skhan@linuxfoundation.org> > > Stable-dep-of: 071af0c9e582 ("selftests: timers: Convert posix_timers test to generate KTAP output") > > Signed-off-by: Edward Liaw <edliaw@google.com> > > --- > > tools/testing/selftests/kselftest.h | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > This commit is already in 6.6.29, why submit it again?
I don't see this in v6.6.29.
The function that it adds is called, but doesn't exist however:
stable/linux-6.6.y:tools/testing/selftests/timers/posix_timers.c: ksft_perror("Can't call gettimeofday()"); stable/linux-6.6.y:tools/testing/selftests/timers/posix_timers.c: ksft_perror("Can't set timer"); stable/linux-6.6.y:tools/testing/selftests/timers/posix_timers.c: ksft_perror("Can't call gettimeofday()"); stable/linux-6.6.y:tools/testing/selftests/timers/posix_timers.c: ksft_perror("Can't create timer"); stable/linux-6.6.y:tools/testing/selftests/timers/posix_timers.c: ksft_perror("Can't call gettimeofday()"); stable/linux-6.6.y:tools/testing/selftests/timers/posix_timers.c: ksft_perror("Can't set timer"); stable/linux-6.6.y:tools/testing/selftests/timers/posix_timers.c: ksft_perror("Can't call gettimeofday()");
We should probably have this added to linux-6.6.y.
-- Lee Jones [李琼斯]
| |