lkml.org 
[lkml]   [2024]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] scsi: csiostor: Use kcalloc() instead of kzalloc()

On Mon, 29 Apr 2024, Kees Cook wrote:

> this isn't a case where we can show identical binary output, since this
> actively adds overflow checking via kcalloc() internals.
>
> ...
>
> it is a trivially correct change that uses a more robust API and more
> idiomatic allocation sizeof()s

If a change is "trivially correct" then the proof is trivial too.

Based only on what you wrote above, omitting the overflow check would give
binary equivalence. That validates the driver change (for hardware you
lack).

But, since a build without the overflow check must contain a second
change, you must validate that change too by showing that kcalloc()
internals still work for every other caller. (You do this using hardware
you have.)

\
 
 \ /
  Last update: 2024-05-27 18:08    [W:0.066 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site