Messages in this thread | | | Subject | Re: [PATCH net v2] vsock/virtio: fix packet delivery to tap device | From | patchwork-bot+netdevbpf@kernel ... | Date | Wed, 03 Apr 2024 01:10:27 +0000 |
| |
Hello:
This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>:
On Fri, 29 Mar 2024 17:12:59 +0100 you wrote: > Commit 82dfb540aeb2 ("VSOCK: Add virtio vsock vsockmon hooks") added > virtio_transport_deliver_tap_pkt() for handing packets to the > vsockmon device. However, in virtio_transport_send_pkt_work(), > the function is called before actually sending the packet (i.e. > before placing it in the virtqueue with virtqueue_add_sgs() and checking > whether it returned successfully). > Queuing the packet in the virtqueue can fail even multiple times. > However, in virtio_transport_deliver_tap_pkt() we deliver the packet > to the monitoring tap interface only the first time we call it. > This certainly avoids seeing the same packet replicated multiple times > in the monitoring interface, but it can show the packet sent with the > wrong timestamp or even before we succeed to queue it in the virtqueue. > > [...]
Here is the summary with links: - [net,v2] vsock/virtio: fix packet delivery to tap device https://git.kernel.org/netdev/net/c/b32a09ea7c38
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |