Messages in this thread | | | Date | Wed, 3 Apr 2024 13:39:41 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH v2] HID: nintendo: Don't fail on setting baud rate |
| |
On Sat, 16 Mar 2024, Max Staudt wrote:
> Some third-party controllers can't change the baud rate. > > We can still use the gamepad as-is, so let's do that. > > Signed-off-by: Max Staudt <max@enpas.org> > --- > Changes in v2: > - Made hid_err() a hid_warn() since it's not a fatal failure. > --- > drivers/hid/hid-nintendo.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c > index 997c3a1adaca..395ed6b5ef59 100644 > --- a/drivers/hid/hid-nintendo.c > +++ b/drivers/hid/hid-nintendo.c > @@ -2164,8 +2164,11 @@ static int joycon_init(struct hid_device *hdev) > /* set baudrate for improved latency */ > ret = joycon_send_usb(ctlr, JC_USB_CMD_BAUDRATE_3M, HZ); > if (ret) { > - hid_err(hdev, "Failed to set baudrate; ret=%d\n", ret); > - goto out_unlock; > + /* > + * We can function with the default baudrate. > + * Provide a warning, and continue on. > + */ > + hid_warn(hdev, "Failed to set baudrate (ret=%d), continuing anyway\n", ret);
Applied, thank you.
-- Jiri Kosina SUSE Labs
| |