lkml.org 
[lkml]   [2024]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/3] serial: 8250_port: Add support of pnp irq to __uart_read_properties()
On Wed, Apr 03, 2024 at 12:54:19PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 03, 2024 at 03:41:29PM +0800, Guanbing Huang wrote:


One more thing, the Subject should start with "serial: port: ..."
And also should have PNP IRQ (capitalized).

> > The function __uart_read_properties doesn't cover pnp devices, so add irq
>
> __uart_read_properties()
>
> PNP
> IRQ
>
> > processing for pnp devices in the branch.
>
> PNP
>
> ...
>
> > #include <linux/property.h>
> > #include <linux/serial_core.h>
> > #include <linux/spinlock.h>
> > +#include <linux/pnp.h>
>
> Keep it ordered (in this context it should go before property.h).

--
With Best Regards,
Andy Shevchenko



\
 
 \ /
  Last update: 2024-05-27 16:20    [W:0.108 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site