Messages in this thread | | | Subject | Re: [PATCH] irqchip/gic-v3-its: Don't need VSYNC if VMAPP with {V, Alloc}=={0, x} | From | Tangnianyao <> | Date | Wed, 3 Apr 2024 16:33:35 +0800 |
| |
On 4/3/2024 14:00, Marc Zyngier wrote: > On Wed, 03 Apr 2024 03:18:51 +0100, > Tangnianyao <tangnianyao@huawei.com> wrote: >> >> >> On 4/2/2024 21:43, Marc Zyngier wrote: >>> On Tue, 02 Apr 2024 14:32:40 +0100, >>> Tangnianyao <tangnianyao@huawei.com> wrote: >>>> >>>> Thank you for quick fix, it would be great to remove this VSYNC. ITS handling VSYNC unmap >>>> vpeid may waste some time, trigger exception and needed to be >>>> handled. >>> Do you actually see an exception being delivered from this? >>> >>> In any case, feel free to respin the patch after having tested this >>> diff, with the commit message fixed and a Fixes: tag attached to it. >> In our developing implemenation, ITS would report RAS when doing vsync >> and reaching an invalid vpe table entry. It is reasonable to report RAS, right? > If a RAS error is the only reporting method you have, then I suspect > you don't have much of a choice (the pseudocode indicates an IMPDEF > SError for VSYNC). Shame this wasn't caught earlier. > >> It just reports, and kernel can still run normally regardless of >> this RAS message. > That really depends on the policy behind RAS errors. > > Looking forward to your respinning of this patch.
I have tested your patch and it's ok to fix the above problem. Respin patch will be sent later.
> > Thanks, > > M. >
| |