Messages in this thread | | | Date | Wed, 3 Apr 2024 09:23:56 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH v3] mtd: rawnand: qcom: Fix broken misc_cmd_type in exec_op |
| |
Hi,
manivannan.sadhasivam@linaro.org wrote on Wed, 3 Apr 2024 12:00:08 +0530:
> On Tue, Apr 02, 2024 at 11:41:34PM +0200, Christian Marangi wrote: > > misc_cmd_type in exec_op have multiple problems. With commit a82990c8a409 > > ("mtd: rawnand: qcom: Add read/read_start ops in exec_op path") it was > > reworked and generalized but actually dropped the handling of the > > OP_RESET_DEVICE command. > > > > The rework itself was correct with supporting case where a single misc > > command is handled, but became problematic by the addition of exiting > > early if we didn't had an OP_BLOCK_ERASE or an OP_PROGRAM_PAGE operation. > > > > Also additional logic was added without clear explaination causing the > > OP_RESET_DEVICE command to be broken on testing it on a ipq806x nandc. > > > > Add some additional logic to restore OP_RESET_DEVICE command handling > > restoring original functionality. > > > > I'd like to reword the commit subject and description as below. But I hope > Miquel can ammend it while applying:
I'm pretty busy, sending a v4 on which you both agree on would be simpler to me :-)
Thanks, Miquèl
| |