lkml.org 
[lkml]   [2024]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4] i2c: i2c-qcom-geni: Parse Error correctly in i2c GSI mode
From
Hi Vinod,

On 3/29/2024 10:15 PM, Vinod Koul wrote:
> On 28-03-24, 08:36, Andi Shyti wrote:
>> Hi
>>
>> On Wed, 13 Mar 2024 10:56:39 +0530, Mukesh Kumar Savaliya wrote:
>>> I2C driver currently reports "DMA txn failed" error even though it's
>>> NACK OR BUS_PROTO OR ARB_LOST. Detect NACK error when no device ACKs
>>> on the bus instead of generic transfer failure which doesn't give any
>>> specific clue.
>>>
>>> Make Changes inside i2c driver callback handler function
>>> i2c_gpi_cb_result() to parse these errors and make sure GSI driver
>>> stores the error status during error interrupt.
>>>
>>> [...]
>>
>> Applied to i2c/i2c-host-next on
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/local tree
>
> You applied changes to dmaengine driver without my ack! I dont agree to
> the approach here, we could do better
>
Could you please suggest changes OR approach related comments ? So i can
make a new change which can clean the merged code ? Hope that can
address the concerns.

\
 
 \ /
  Last update: 2024-05-27 16:20    [W:0.989 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site