lkml.org 
[lkml]   [2024]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 18/31] hwmon: (lm95234) Remove use of i2c_match_id()
    Date
    The function i2c_match_id() is used to fetch the matching ID from
    the i2c_device_id table. This is often used to then retrieve the
    matching driver_data. This can be done in one step with the helper
    i2c_get_match_data().

    This helper has a couple other benefits:
    * It doesn't need the i2c_device_id passed in so we do not need
    to have that forward declared, allowing us to remove those or
    move the i2c_device_id table down to its more natural spot
    with the other module info.
    * It also checks for device match data, which allows for OF and
    ACPI based probing. That means we do not have to manually check
    those first and can remove those checks.

    Signed-off-by: Andrew Davis <afd@ti.com>
    ---
    drivers/hwmon/lm95234.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/hwmon/lm95234.c b/drivers/hwmon/lm95234.c
    index 67b9d7636ee42..be00a374632d3 100644
    --- a/drivers/hwmon/lm95234.c
    +++ b/drivers/hwmon/lm95234.c
    @@ -677,10 +677,9 @@ static int lm95234_init_client(struct i2c_client *client)
    return 0;
    }

    -static const struct i2c_device_id lm95234_id[];
    -
    static int lm95234_probe(struct i2c_client *client)
    {
    + enum chips type = (uintptr_t)i2c_get_match_data(client);
    struct device *dev = &client->dev;
    struct lm95234_data *data;
    struct device *hwmon_dev;
    @@ -699,7 +698,7 @@ static int lm95234_probe(struct i2c_client *client)
    return err;

    data->groups[0] = &lm95234_common_group;
    - if (i2c_match_id(lm95234_id, client)->driver_data == lm95234)
    + if (type == lm95234)
    data->groups[1] = &lm95234_group;

    hwmon_dev = devm_hwmon_device_register_with_groups(dev, client->name,
    --
    2.39.2

    \
     
     \ /
      Last update: 2024-05-27 16:22    [W:4.660 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site