| Date | Wed, 3 Apr 2024 20:46:53 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v3 11/25] media: i2c: imx258: Add get_selection for pixel array information |
| |
Hi!
> Libcamera requires the cropping information for each mode, so > add this information to the driver.
> @@ -116,6 +124,9 @@ struct imx258_mode { > u32 link_freq_index; > /* Default register values */ > struct imx258_reg_list reg_list; > + > + /* Analog crop rectangle. */
No need for "." at the end, as it is not above.
> + struct v4l2_rect crop; > };
If the crop is same in all modes, should we have it in common place?
Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates. [unhandled content-type:application/pgp-signature] |