lkml.org 
[lkml]   [2024]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v19 106/130] KVM: TDX: Add KVM Exit for TDX TDG.VP.VMCALL
    On Mon, Feb 26, 2024 at 12:26:48AM -0800, isaku.yamahata@intel.com wrote:
    >From: Isaku Yamahata <isaku.yamahata@intel.com>
    >
    >Some of TDG.VP.VMCALL require device model, for example, qemu, to handle
    >them on behalf of kvm kernel module. TDVMCALL_REPORT_FATAL_ERROR,
    >TDVMCALL_MAP_GPA, TDVMCALL_SETUP_EVENT_NOTIFY_INTERRUPT, and
    >TDVMCALL_GET_QUOTE requires user space VMM handling.
    >
    >Introduce new kvm exit, KVM_EXIT_TDX, and functions to setup it. Device
    >model should update R10 if necessary as return value.
    >
    >Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
    >---
    >v14 -> v15:
    >- updated struct kvm_tdx_exit with union
    >- export constants for reg bitmask
    >
    >Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
    >---
    > arch/x86/kvm/vmx/tdx.c | 83 ++++++++++++++++++++++++++++++++++++-
    > include/uapi/linux/kvm.h | 89 ++++++++++++++++++++++++++++++++++++++++
    > 2 files changed, 170 insertions(+), 2 deletions(-)
    >
    >diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c
    >index c8eb47591105..72dbe2ff9062 100644
    >--- a/arch/x86/kvm/vmx/tdx.c
    >+++ b/arch/x86/kvm/vmx/tdx.c
    >@@ -1038,6 +1038,78 @@ static int tdx_emulate_vmcall(struct kvm_vcpu *vcpu)
    > return 1;
    > }
    >
    >+static int tdx_complete_vp_vmcall(struct kvm_vcpu *vcpu)
    >+{
    >+ struct kvm_tdx_vmcall *tdx_vmcall = &vcpu->run->tdx.u.vmcall;
    >+ __u64 reg_mask = kvm_rcx_read(vcpu);
    >+
    >+#define COPY_REG(MASK, REG) \
    >+ do { \
    >+ if (reg_mask & TDX_VMCALL_REG_MASK_ ## MASK) \
    >+ kvm_## REG ## _write(vcpu, tdx_vmcall->out_ ## REG); \
    >+ } while (0)

    Why XMMs are not copied?

    Looks you assume the guest won't use XMMs for TDVMCALL. But I think the ABI
    (KVM_EXIT_TDX) should be general, i.e., can support all kinds of (future)
    TDVMCALLs.

    >+
    >+
    >+ COPY_REG(R10, r10);
    >+ COPY_REG(R11, r11);
    >+ COPY_REG(R12, r12);
    >+ COPY_REG(R13, r13);
    >+ COPY_REG(R14, r14);
    >+ COPY_REG(R15, r15);
    >+ COPY_REG(RBX, rbx);
    >+ COPY_REG(RDI, rdi);
    >+ COPY_REG(RSI, rsi);
    >+ COPY_REG(R8, r8);
    >+ COPY_REG(R9, r9);
    >+ COPY_REG(RDX, rdx);
    >+
    >+#undef COPY_REG
    >+
    >+ return 1;
    >+}

    \
     
     \ /
      Last update: 2024-05-27 16:20    [W:2.947 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site