Messages in this thread | | | Date | Mon, 29 Apr 2024 12:01:10 -0400 | From | Frank Li <> | Subject | Re: [PATCH v3 04/11] PCI: imx6: Rename pci-imx6.c to pcie-imx.c |
| |
On Sat, Apr 27, 2024 at 03:01:33PM +0530, Manivannan Sadhasivam wrote: > On Tue, Apr 02, 2024 at 10:33:40AM -0400, Frank Li wrote: > > Update the filename from 'pci-imx6.c' to 'pcie-imx.c' to accurately reflect > > its applicability to all i.MX chips (i.MX6x, i.MX7x, i.MX8x, i.MX9x). > > Eliminate the '6' to prevent confusion. Additionally, correct the prefix > > from 'pci-' to 'pcie-'. > > > > Retain the previous configuration CONFIG_PCI_IMX6 unchanged to maintain > > compatibility. > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > You should not rename a driver as that will break existing userspace scripts > looking for module with old name.
Generally, pcie-driver will be not built as module. Anyway, it will not big benefit by rename after second think. Let's keep the old name.
Frank
> > - Mani > > > --- > > drivers/pci/controller/dwc/Makefile | 2 +- > > drivers/pci/controller/dwc/{pci-imx6.c => pcie-imx.c} | 0 > > 2 files changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/controller/dwc/Makefile b/drivers/pci/controller/dwc/Makefile > > index bac103faa5237..eaea7abbabc2c 100644 > > --- a/drivers/pci/controller/dwc/Makefile > > +++ b/drivers/pci/controller/dwc/Makefile > > @@ -7,7 +7,7 @@ obj-$(CONFIG_PCIE_BT1) += pcie-bt1.o > > obj-$(CONFIG_PCI_DRA7XX) += pci-dra7xx.o > > obj-$(CONFIG_PCI_EXYNOS) += pci-exynos.o > > obj-$(CONFIG_PCIE_FU740) += pcie-fu740.o > > -obj-$(CONFIG_PCI_IMX6) += pci-imx6.o > > +obj-$(CONFIG_PCI_IMX6) += pcie-imx.o > > obj-$(CONFIG_PCIE_SPEAR13XX) += pcie-spear13xx.o > > obj-$(CONFIG_PCI_KEYSTONE) += pci-keystone.o > > obj-$(CONFIG_PCI_LAYERSCAPE) += pci-layerscape.o > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pcie-imx.c > > similarity index 100% > > rename from drivers/pci/controller/dwc/pci-imx6.c > > rename to drivers/pci/controller/dwc/pcie-imx.c > > > > -- > > 2.34.1 > > > > -- > மணிவண்ணன் சதாசிவம்
| |